• Daniel Murphy's avatar
    Revert "[signin] Don't clear unconsented primary account on cancelling Sync dialog" · f636d94d
    Daniel Murphy authored
    This reverts commit f21f4c91.
    
    Reason for revert: Seems to be causing SingleClientStandaloneTransportSyncTest.HandlesResetFromDashboardWhenSyncActive to fail
    
    Bug: 1029869
    
    Original change's description:
    > [signin] Don't clear unconsented primary account on cancelling Sync dialog
    > 
    > The unconsented primary account doesn't necessarily change when the Sync
    > confirmation dialog is cancelled.
    > In particular this is the case when PrimaryAccountMutator::ClearPrimaryAccount
    > is called with RemoveAccountOptions::kKeepAll.
    > 
    > This CL stops resetting the unconsented primary account as part of the signout
    > process.
    > The unconsented primary account is recomputed anyway when GoogleSignedOut is
    > called.
    > 
    > 
    > Fixed: 1029701
    > Change-Id: Id46bb468952efe63170a13872519fcaded076cb1
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944862
    > Commit-Queue: David Roger <droger@chromium.org>
    > Reviewed-by: Monica Basta <msalama@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#720502}
    
    TBR=droger@chromium.org,msalama@chromium.org
    
    Change-Id: I0632406070243902295db9f9e482f161df6e65ce
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946194Reviewed-by: default avatarDaniel Murphy <dmurph@chromium.org>
    Commit-Queue: Daniel Murphy <dmurph@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#720570}
    f636d94d
primary_account_manager.cc 14.7 KB