• Mikel Astiz's avatar
    Reland "Send variation headers to sync server" · f66cb726
    Mikel Astiz authored
    This is a reland of
    https://chromium-review.googlesource.com/c/chromium/src/+/1827368 after
    the underlying issues have been resolved in other patches and
    FieldTrialList is guaranteed to be instantiated on all platforms.
    
    Original change's description:
    > Revert "Send variation headers to sync server"
    >
    > This reverts commit c305a2ba.
    >
    > Reason for revert: DCHECK failures observed on ios.
    >
    > Original change's description:
    > > Send variation headers to sync server
    > >
    > > This information is already sent to other servers such as the one used
    > > for omnibox personalization, hence the patch doesn't upload additional
    > > information but allows measuring the impact variations have on the sync
    > > server and debug errors caused by client-side experiments.
    > >
    > > Bug: 887521
    > > Change-Id: I3358956639bf96260bb5010279012195086eec37
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827368
    > > Reviewed-by: Mark Pearson <mpearson@chromium.org>
    > > Reviewed-by: Marc Treib <treib@chromium.org>
    > > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#700678}
    >
    > TBR=mpearson@chromium.org,treib@chromium.org,mastiz@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: 887521, 1011088
    > Change-Id: I07fb576d156cf9efd334ce89617e9a823db61662
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844814
    > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#703254}
    
    TBR=mpearson@chromium.org,treib@chromium.org,mastiz@chromium.org
    
    Bug: 887521, 1011088
    Change-Id: I1e7ee5d44d1137dfaa5bdc7dd063cfe8bd2b7e55
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950947
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#721635}
    f66cb726
http_bridge.cc 16.9 KB