GitLab

This reverts commit eabc228b.

Reason for revert: May have caused a compile error that closed the tree: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-webview/2197

Original change's description:
> Fix DownloadManagerTestCase flakiness.
> 
> On iOS 12 URLSession:dataTask:didReceiveData: delegate method can be
> called when task is in NSURLSessionTaskStateCompleted state. This
> resulted in extra URLFetcherResponseWriter::Finish call (one from
> didReceiveData: and one from didCompleteWithError:).
> URLFetcherResponseWriter::Finish DCHECKs if Finish is called twice, so
> the test was flaky.
> 
> This CL changes DownloadTaskImpl to only call
> URLFetcherResponseWriter::Finish from didCompleteWithError:.
> 
> Bug: 873204
> Change-Id: Ie6b8757e2c5c5d35da088fd108d92ee3ed13244d
> Reviewed-on: https://chromium-review.googlesource.com/c/1354233
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Commit-Queue: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#612249}

TBR=sdefresne@chromium.org,eugenebut@chromium.org

Change-Id: I1f7e7620911c73ce1f497fb6ae7b09ed16a2547f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 873204
Reviewed-on: https://chromium-review.googlesource.com/c/1355600Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612251}