-
Yuheng Huang authored
Reason for the revert: Because tab search is disabled when #top-chrome-touch-ui is enabled, it fails on chromeos-eve-chrome, which is a touch based device and have #top-chrome-touch-ui enabled. Solution: 1. Disable #top-chrome-touch-ui for this test 2. Add a small delay to open tabs 3. Exclude UNSCHEDULED_tab_search from benchmark_smoke_unittest While the 1st change fixes the failure of chromeos-eve-chrome, it's safer to exclude UNSCHEDULED_tab_search from the test in case it breaks other trybots. We will reenable it in a follow up CL when we have more confidence this test can pass all trybots. This is a reland of 683608bf Original change's description: > Tab Search: Implement performance benchmark > > Doc: > https://docs.google.com/document/d/1-1ijT7wt05hlBZmSKjX_DaTCzVqpxbfTM1y-j7kYHlc > Usage: > tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top10:2020 > tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top50:2020 > tools/perf/run_benchmark run UNSCHEDULED_tab_search --browser-executable=out/Default/chrome --story-filter=tab_search:top100:2020 > > Change-Id: I684024f9cf3264ac2ed4feca15c6059342a493c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461224 > Commit-Queue: Yuheng Huang <yuhengh@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824599} Change-Id: I99a1b357e9d1e911a6966180df15d025faa27e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523752Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#825457}
f692adcf