• Alex Moshchuk's avatar
    Revert "[omnibox] Add tests for dedicated row and pedals a11y" · f6fa5f43
    Alex Moshchuk authored
    This reverts commit 4dfbdf6a.
    
    Reason for revert: The EmitAccessibilityEventsOnButtonFocusHint test that's modified here is failing on Mac10.11:
    https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/53696
    
    Failure output:
    [ RUN      ] All/OmniboxPopupContentsViewTest.EmitAccessibilityEventsOnButtonFocusHint/1
    [26756:3843:0819/131719.560091:WARNING:notification_platform_bridge_mac.mm(572)] AlertNotificationService: XPC connection invalidated.
    ../../chrome/browser/ui/views/omnibox/omnibox_popup_contents_view_browsertest.cc:163: Failure
    Value of: contains(omnibox_value(), expected_value)
      Actual: false
    Expected: true
    Google Test trace:
    ../../chrome/browser/ui/views/omnibox/omnibox_popup_contents_view_browsertest.cc:162: Omnibox value (foo/, 2 of 3) is expected to contain "The Foo Of All Bars"
    Stack trace:
    0   browser_tests                       0x00000001072bee49 (anonymous namespace)::TestAXEventObserver::CheckOmniboxValue(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >) + 825
    1   browser_tests                       0x00000001072bda50 OmniboxPopupContentsViewTest_EmitAccessibilityEventsOnButtonFocusHint_Test::RunTestOnMainThread() + 640
    2   browser_tests                       0x000000010c21394d content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 717
    
    Original change's description:
    > [omnibox] Add tests for dedicated row and pedals a11y
    > 
    > Added tests for keyword button, pedal button, remove suggestion button,
    > multiple buttons for one suggestion (tab switch and keyword button).
    > Cleaned up tests.
    > 
    > Fixed a11y for remove suggestion button and buttons in dedicated row
    > (set role to be list box option and set correct accessible name).
    > Fixed selection event not being triggered for dedicated row buttons
    > (GetSecondaryButton wasn't returning buttons from dedicated row).
    > Fixed value changed event triggering extra time when switching selection
    > from button to button.
    > 
    > Bug: 1104264
    > Change-Id: I0c7a7a9cee0622cce2a24f6ea58c73a56ac996bc
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352826
    > Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com>
    > Reviewed-by: Bret Sepulveda <bsep@chromium.org>
    > Reviewed-by: Tommy Li <tommycli@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#799723}
    
    TBR=tommycli@chromium.org,bsep@chromium.org,olesiamarukhno@google.com
    
    Change-Id: I97466a40db517ef10dc138ebbea1a0d8569e0a3e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1104264
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364961Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
    Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#799799}
    f6fa5f43
omnibox_result_view.cc 22.9 KB