• Dominic Farolino's avatar
    Revert "Reland "[Prefetch]: DCHECK if recursive prefetch token is set incorrectly"" · f71656d5
    Dominic Farolino authored
    This reverts commit 422bc672.
    
    Reason for revert: We've collected enough info
    
    Original change's description:
    > Reland "[Prefetch]: DCHECK if recursive prefetch token is set incorrectly"
    >
    > This reverts commit 2638a6e6.
    >
    > Reason for revert: We thought we had collected enough crash data, however crbug.com/1122182 was not actually fixed yet, so the minidumps did not actually contain the information we needed. agrieve@ has informed me that the issue should be fixed now, and we'll confirm whether or not that is the case by:
    >  1.) Reverting this change
    >  2.) Collecting minidumps
    >  3.) Examining the minidumps to confirm that the debugging information exists
    >
    > Original change's description:
    > > Revert "[Prefetch]: DCHECK if recursive prefetch token is set incorrectly"
    > >
    > > This reverts commit b344652b.
    > > Reason for revert: We have collected enough crashdumps now, and this is
    > > causing crash metrics to be skewed as it's getting counted as a real
    > > crash.
    > >
    > > Bug: 1132770
    > > Change-Id: Ia2e7a92bea2ebeca01c62ca9af73d3fe014685f6
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505985
    > > Auto-Submit: Mugdha Lakhani <nator@chromium.org>
    > > Commit-Queue: Charlie Harrison <csharrison@chromium.org>
    > > Reviewed-by: Charlie Harrison <csharrison@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#822189}
    >
    > TBR=csharrison@chromium.org,nator@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > TBR: charrison@chromium.org
    > Bug: 1132770
    > Change-Id: I31ac96c2c5f4f0738fd2d8c4e60236b2bc0c35a3
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513109
    > Reviewed-by: Charlie Harrison <csharrison@chromium.org>
    > Reviewed-by: Mugdha Lakhani <nator@chromium.org>
    > Reviewed-by: Dominic Farolino <dom@chromium.org>
    > Commit-Queue: Dominic Farolino <dom@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#829091}
    
    TBR=csharrison@chromium.org,dom@chromium.org,nator@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1132770
    Change-Id: Ie8515e382ba8d4610aaeb3026909bec63a1e9405
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568110
    Commit-Queue: Dominic Farolino <dom@chromium.org>
    Reviewed-by: default avatarDominic Farolino <dom@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#832416}
    f71656d5
prefetch_url_loader_service.cc 15.4 KB