• Adam Rice's avatar
    Revert "Use PaintInvalidator to optimize AX bounding boxes" · f719bbea
    Adam Rice authored
    This reverts commit fd1c45a7.
    
    Reason for revert: Causing test AccessibilityActionBrowserTest.IncrementDecrementActions to fail. See for example https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19799.
    
    Original change's description:
    > Use PaintInvalidator to optimize AX bounding boxes
    > 
    > Previously, any time there was a layout, the accessibility
    > serialization code would scan every AXObject to see if any
    > needed to update their bounding box.
    > 
    > Instead, replace this with a mechanism that uses
    > PaintInvalidator to mark AXObjects that might have
    > dirty bounding boxes.
    > 
    > Existing tests already provide some coverage; if you
    > comment out the code in paint_invalidator.cc, a
    > handful of browser tests fail.
    > 
    > To provide even more coverage, a debug-only check
    > walks the entire tree and ensures that no nodes
    > have incorrect bounding boxes. If you try commenting
    > out the code in paint_invalidator.cc now, hundreds
    > of browser tests fail. This provides some good
    > confidence that it's working correctly.
    > 
    > Finally, add a new blink perf test demonstrating a
    > simple scenario where this results in a dramatic
    > speedup, just by focusing links in a document with a
    > few thousand nodes.
    > 
    > Bug: 1109081
    > AX-Relnotes: makes accessibility less sluggish on very large web pages
    > 
    > Change-Id: I51a89d0b37ff356c5443b324080acefe0e7f3fbf
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319411
    > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
    > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    > Reviewed-by: Kentaro Hara <haraken@chromium.org>
    > Reviewed-by: Nektarios Paisios <nektar@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#792949}
    
    TBR=dmazzoni@chromium.org,wangxianzhu@chromium.org,aboxhall@chromium.org,haraken@chromium.org,nektar@chromium.org
    
    Change-Id: I3f44fc1c97dbe1690b881cb233b46f060f49ca72
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1109081
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326560Reviewed-by: default avatarAdam Rice <ricea@chromium.org>
    Commit-Queue: Adam Rice <ricea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#793039}
    f719bbea
render_accessibility_impl.cc 50.1 KB