• Peter Wen's avatar
    Android: Use per-target lint-suppressions.xml · f74622e6
    Peter Wen authored
    Previously all lint targets shared one lint suppressions/config file:
    //build/android/lint/suppressions.xml
    
    This resulted in many unnecessary suppressions being added which then
    suppress the lint checks for every lint target. e.g. if monochrome fails
    ObsoleteSdkInt checks, suppressing it globally turns off the checks for
    all other apks, which decreases the utility of android lint for all
    those other apks.
    
    This CL removes the shared suppressions.xml file and splits its content
    between the targets that actually need them, and adds lint-baseline.xml
    files where necessary. This also removes the bottleneck of requiring a
    //build/android/OWNERS to stamp every lint suppression change.
    
    This CL also adds suppressions for targets depending on code that chrome
    already lints via monochrome. E.g. errors in //base are shared by all
    embedders' lint targets, and it should not become the burden of targets
    like cast shell or cronet to fix. Thus these errors are suppressed in
    cronet/cast/remoting-specific suppressions.xml files.
    
    This CL changes lint to run in the output directory so that baseline
    suppressions work for generated files (e.g. AndroidManifest.xml).
    
    Bug: 1113795,1115594
    Fixes: 1115594
    Change-Id: I2d70128707c0fa862c109b6f91631a07916c90d6
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346857
    Commit-Queue: Peter Wen <wnwen@chromium.org>
    Reviewed-by: default avatarYuchen Liu <yucliu@chromium.org>
    Reviewed-by: default avatarPaul Jensen <pauljensen@chromium.org>
    Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
    Reviewed-by: default avatarBo <boliu@chromium.org>
    Reviewed-by: default avatarLambros Lambrou <lambroslambrou@chromium.org>
    Auto-Submit: Peter Wen <wnwen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#798776}
    f74622e6
AndroidManifest.xml 1.21 KB