• Rune Lillesveen's avatar
    Revert "window-service: ignore requests to focus null" · f792e7d8
    Rune Lillesveen authored
    This reverts commit d00fd143.
    
    Reason for revert: Caused test flakiness https://crbug.com/871652
    
    Original change's description:
    > window-service: ignore requests to focus null
    > 
    > Here's my comment as to why this is ignored:
    > 
    >   // The client is asking to remove focus from a window. This is typically a
    >   // side effect of the window becoming, or about to become, an unfocusable
    >   // Window (for example, the Window is hiding). Windows becoming unfocusable is
    >   // handled locally. Assume the request is for such a scenario and return
    >   // false to ignore the change.
    >   //
    >   // To process null requests conflicts with top-level activation changes. For
    >   // example, the typical sequence when a window is hidden is to first remove
    >   // focus, and then hide the window. FocusController keys off window hiding to
    >   // move activation. If this code where to set focus to null, FocusController
    >   // would not see the window hiding (because the active window was set to null)
    >   // and not automatically activate the next window.
    >   //
    >   // Another possibility for this code is to handle null as a signal to move
    >   // focus to the active window (if there is one). I'm going with the simpler
    >   // approach for now.
    > 
    > BUG=867654
    > TEST=covered by tests
    > 
    > Change-Id: Iee8efd8895284acca4603ff22bde19adf16d8a7f
    > Reviewed-on: https://chromium-review.googlesource.com/1164409
    > Reviewed-by: Michael Wasserman <msw@chromium.org>
    > Commit-Queue: Scott Violet <sky@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#581113}
    
    TBR=sky@chromium.org,msw@chromium.org
    
    Change-Id: I7710ea88b1dcb53d5ad299ff1295ecec31ce3f87
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 867654
    Reviewed-on: https://chromium-review.googlesource.com/1164782Reviewed-by: default avatarRune Lillesveen <futhark@chromium.org>
    Commit-Queue: Rune Lillesveen <futhark@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#581148}
    f792e7d8
main.cc 2.72 KB