• zxliang's avatar
    Check external_services_to_proxy for interfaces from external services · f7a0342e
    zxliang authored
    If a service appears in external_services_to_proxy, it is supposed to be
    registered and stored in services_ as well. BindInterface() should not
    query ServiceManager but instead should store this request through
    ServiceNotFound for later query when that particular external service is
    registered through RegisterExternalServices(..). Otherwise the binding
    process to this external service (which only has earlier-registered
    service_instance) will be silently dropped if the the client doesn't
    set any disconnection handler.
    
    Refer to go/ml-framework-standalone-binary-flakiness for more info.
    
    Bug: b/168555534
    Test: CQ
    
    Change-Id: I2f791c924e1b23518704ad7237fc1e5624eaefd8
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537975
    Commit-Queue: Zhaoxin Liang <zxliang@google.com>
    Reviewed-by: default avatarKenneth MacKay <kmackay@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#827706}
    f7a0342e
external_mojo_broker.cc 16.6 KB