• Mike Wittman's avatar
    [Sampling profiler] Restore V8Unwinder embedded code range · f7f4abdd
    Mike Wittman authored
    Restores a separate representation of the V8 embedded code range as
    compared to runtime-generated code ranges, now that V8 provides access
    to this state in the API. This distinction was made in an earlier
    version of the V8 unwind API but the current version did not previously
    expose the necessary information. Representing the embedded code range
    allows profiling of JavaScript builtins which live within the range.
    
    Along the way fixes a bug in StackSamplerImpl where the unwinder's
    AddInitialModules was invoked twice if the unwinder was added before
    profiling started.
    
    Fixed: 1136256
    Change-Id: I6ec1433fcf5b7704cb9022781edc423d027b8da9
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476626
    Commit-Queue: Mike Wittman <wittman@chromium.org>
    Auto-Submit: Mike Wittman <wittman@chromium.org>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Reviewed-by: default avatarEtienne Pierre-Doray <etiennep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#820934}
    f7f4abdd
stack_sampler_impl.cc 7.35 KB