• Benjamin Beaudry's avatar
    Reland "PDF a11y: kTextDirection attribute support" · f80f4b5f
    Benjamin Beaudry authored
    This is a reland of [1] reverted in [2]. The test failure comes from [3]
    that got merged a few minutes before [1]. The test expectations are now
    updated to work with the changes brought by [3] to paragraphs break
    heuristics.
    
    [1] Original CL: crrev.com/753f8707
    [2] Reverted in: crrev.com/003b20ab
    [3] Caused by: crrev.com/f39b7b73
    
    Original change's description:
    > PDF a11y: kTextDirection attribute support
    >
    > The text direction attribute is now properly set for text runs in PDF.
    > It is inferred by the position of the first and the last characters of
    > a text run.
    >
    > This change includes a pdf-template file (text-direction.in) with RTL
    > text representation used to generate our unit test PDF file.
    >
    > Bug: 985604
    > Change-Id: If5d82296463331e95c4ded4e5244d65be3fbadfa
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737019
    > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
    > Reviewed-by: Lei Zhang <thestig@chromium.org>
    > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#690163}
    
    Change-Id: Ic8b7e62d1bce71db39af01473a66ea033aeaf7a1
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771551
    Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
    Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Reviewed-by: default avatarKevin Babbitt <kbabbitt@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#690395}
    f80f4b5f
pdfium_engine.h 27.2 KB