GitLab

No change to logic.

This simplifies aw_cookie_access_policy.cc:

 - Inline AwStaticCookiePolicy's body into AwCookieAccessPolicy
 - Rename AwStaticCookiePolicyTest to AwStaticCookiePolicyTest and
   rewrite the tests
 - Consolidate AwCookieAccessPolicy's SetCookie+GetCookie methods into
   AllowCookies() overrides, since we don't distinguish between setting
   and getting
 - Add DCHECKs for threading and to mark the legacy code path
 - Update callsites to use the AllowCookies() methods

This also adds unit test coverage for WebView's special handling of
file:// scheme cookies.

Bug: 932535
Test: run_webview_instrumentation_test_apk -f CookieManagerTest#*
Test: run_android_webview_unittests -f AwStaticCookiePolicyTest.*
Cq-Include-Trybots: luci.chromium.try:android_mojo
Change-Id: I457279d089c347f286f939e2cdcec9e371803730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548511Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#648336}