• Abigail Klein's avatar
    [Live Caption] Remove "Detecting speech..." message. · f857cc1f
    Abigail Klein authored
    The UI showed a "Detecting speech..." message in the caption bubble as
    soon as audio started playing to alert the user that Live Caption was
    beginning to detect speech. This caused a bug in which the caption
    bubble appeared when audio that does not contain speech began to play,
    such as short pings. The team decided to remove the "Detecting
    speech..." message from the UI as a result.
    
    This CL removes the text from the UI and removes the
    OnSpeechRecognitionReady message sent from the
    ChromeSpeechRecognitionClient to the caption UI, which is no longer
    necessary. It also introduces a new accessible label for the caption
    bubble, which is necessary so that the bubble can set the AXNodeData
    name when the bubble label does not contain any text.
    
    Bug: 1055150, 1114232
    Change-Id: I85fdab48a34176e67733f4540ec534c6e7e0109f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368464Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Reviewed-by: default avatarTom Sepez <tsepez@chromium.org>
    Commit-Queue: Abigail Klein <abigailbklein@google.com>
    Cr-Commit-Position: refs/heads/master@{#801097}
    f857cc1f
caption_controller.h 3.8 KB