• Elly Fong-Jones's avatar
    bookmarks: show ampersands in bookmark titles in app menu · f8b6b9dc
    Elly Fong-Jones authored
    This change:
    1) Moves and renames ui::EscapeWindowsStyleAccelerators to make it available on
       other platforms;
    2) Has BookmarkMenuDelegate call that function if the bookmark menu is being
       shown in the app menu;
    3) Has BackForwardMenuModel call that function instead of hand-rolling escaping
    
    In MenuItemViews whose root MenuItemView has_mnemonics(), '&' is interpreted
    as a mnemonic marker, which makes it necessary to escape them.
    
    Bug: 896550,788049
    Change-Id: I83f6bc6f5b71efa1d7220d8d20afa7dd833771ba
    Reviewed-on: https://chromium-review.googlesource.com/c/1287325Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#601744}
    f8b6b9dc
bookmark_menu_delegate.h 8.33 KB