• xidachen's avatar
    Minor clean up in transferToImageBitmap API · f92c2854
    xidachen authored
    The transferToImageBitmap is an API in OffscreenCanvas. This API could
    throw exception in certain cases, which means that the
    OffscreenCanvas::transferToImageBitmap() method has a ExceptionState&
    parameter.
    
    In our current implementation, we do all the exception check in the above
    method. However, we still pass the ExceptionState& parameter to the
    CanvasRenderingContext::transferToImageBitmap() method, and this method
    is overriden by OffscreenCanvasRenderingContext2D, WebGLRenderingContext,
    and WebGL2RenderingContext. So this method in all these sub-classes also
    take a ExceptionState& parameter but do nothing with it. We should not
    need to pass this parameter to CanvasRenderingContext::transferToImageBitmap.
    
    TBR=kbr@chromium.org, zmo@chromium.org
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
    
    Review-Url: https://codereview.chromium.org/2440213003
    Cr-Commit-Position: refs/heads/master@{#427188}
    f92c2854
WebGL2RenderingContext.cpp 6.9 KB