• Brian Sheedy's avatar
    Fix GPU stack symbolization on Android · f95901b3
    Brian Sheedy authored
    Adds the necessary Chromium-side changes to fix stack symbolization for
    non-browser crashes in GPU Telemetry tests on Android. Specifically:
    
    1. Makes the GPU tests use GetStackTrace() on Android instead of
       LogSymbolizedUnsymbolizedMinidumps(), as this is currently the only
       way to get stack traces through Telemetry on Android.
    2. Adds a --breakpad-dump-location argument to ChromeCrashReporterClient
       that is functionally equivalent to the existing
       BREAKPAD_DUMP_LOCATION environment variable, but necessary for
       Android since we can't set environment variables before launching
       Chrome on Android.
    3. Moves the dump location override to ChromeCrashReporterClient::Create
       instead of whe retrieving the crash dump location in order to avoid
       issues with Android calling blocking functions in a scope that does
       not allow blocking functions.
    
    Bug: 949321
    Change-Id: I9be2446a73a2359157cd94c889bf34951b78c86b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825719
    Commit-Queue: Robert Sesek <rsesek@chromium.org>
    Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
    Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#700407}
    f95901b3
chrome_crash_reporter_client.cc 6.21 KB