• Elly Fong-Jones's avatar
    views: introduce DialogDelegate::SetExtraView · f96f7903
    Elly Fong-Jones authored
    This method takes ownership of a View to use for the dialog's extra view
    slot. This change also has the default implementation of
    DialogDelegate::CreateExtraView return the view provided by
    SetExtraView. It then migrates some users of CreateExtraView to use
    SetExtraView, from their constructors if possible, by:
    
    1) Moving their Foo::CreateExtraView method to a free function inside an
       anonymous namespace
    2) Invoking it from their constructor, and storing a weak raw pointer to
       the created View if needed
    
    Further CLs will remove other uses of CreateExtraView and eventually
    remove it in favor of DialogDelegate pushing the extra view to
    DialogClientView.
    
    Bug: 1011446
    Change-Id: If3a9f3ebe086122dc28b76c233193e7cfb4c0152
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865597Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#707209}
    f96f7903
chooser_dialog_view.h 1.73 KB