• Ahmed Fakhry's avatar
    Revert "Hide option to remap internal search when no internal KB is connected" · f9b3baff
    Ahmed Fakhry authored
    This reverts commit 4c097c39.
    
    Reason for revert: I found a bug in internal keyboard detection. I will reland with fix to be able to merge to M-71.
    
    Original change's description:
    > Hide option to remap internal search when no internal KB is connected
    > 
    > To avoid confusion when there is no internal keyboard connected:
    > - We should not show the option to remap the internal "Search"
    > key since that key doesn't exist.
    > - We should also avoid labeling the options to remap the external
    > meta keys as "External Meta" or "External Command", and just say
    > "Meta" or "Command" as "External" here is redundant.
    > 
    > BUG=890522, 890950
    > TEST=Expanded existing tests.
    > 
    > Change-Id: If979b80217298a5f6bb18be478aa2c457859a351
    > Reviewed-on: https://chromium-review.googlesource.com/c/1253022
    > Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
    > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#599409}
    
    TBR=stevenjb@chromium.org,afakhry@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 890522, 890950
    Change-Id: I9cd4273a61c51751a20d8bbffbf7fffbb252246c
    Reviewed-on: https://chromium-review.googlesource.com/c/1292816Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
    Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#601391}
    f9b3baff
keyboard.html 6.28 KB