GitLab

The predicate that determines whether sync allows uploading
demographics metrics now adopts GetUploadToGoogleState(), which is
the standard way to implement this kind of logic.

Note that the patch can have behavioral differences because it's more
strict. These changes are expected to be very small and even desirable,
for example:
1. If user manually disabled sync-ing of preferences, then the new
   predicate will return false.
2. If there is permanent auth error (other than user signout, which was
   already handled before), the new predicate will return false.

Change-Id: I05f1c93ba6028cc4c91b790fd142b494d499d837
Bug: 1137346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467519Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822565}