• Dan H's avatar
    Revert "Better coordinate swipe to home gesture and drag handle nudge" · fc531456
    Dan H authored
    This reverts commit 57098dce.
    
    Reason for revert: Causing test failures: https://bugs.chromium.org/p/chromium/issues/detail?id=1062658
    
    Original change's description:
    > Better coordinate swipe to home gesture and drag handle nudge
    > 
    > Manages the drag handle nudge during window drag from shelf to home or
    > overview (which may end up in a gesture the nudge is describing).
    > 
    > If the contextual nudge is shown when the window drag starts, the nudge
    > will not be hidden until the gesture completes (end it will get hidden
    > when the gesture completes, even if the user does not end up going
    > home).
    > 
    > If the contextual nudge is scheduled to be shown when the gesture
    > starts, the show request will be canceled.
    > 
    > Adds logic that prevents drag handle nudge from showing up, unless it's
    > a result of an explicit user action - tapping the drag handle.
    > 
    > BUG=1058617
    > 
    > Change-Id: I96fa2748308143ec42295dbfb472dc564da5bd03
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107135
    > Commit-Queue: Toni Baržić <tbarzic@chromium.org>
    > Reviewed-by: Manu Cornet <manucornet@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#751200}
    
    TBR=tbarzic@chromium.org,manucornet@chromium.org,yulunwu@chromium.org
    
    Change-Id: I361894e79bf7bb027f690f5a6310874341d51ecf
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1058617
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108525Reviewed-by: default avatarDan H <harringtond@chromium.org>
    Commit-Queue: Dan H <harringtond@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#751360}
    fc531456
shelf_drag_handle_unittest.cc 15.8 KB