• scottmg's avatar
    Fix variable shadowing warning in logging on VS2015 · fc5b7077
    scottmg authored
    d:\src\cr3\src\base\logging.cc(167): error C2220: warning treated as error - no 'object' file generated
    d:\src\cr3\src\base\logging.cc(167): warning C4459: declaration of 'log_file' hides global declaration
    d:\src\cr3\src\base\logging.cc(103): note: see declaration of 'logging::`anonymous-namespace'::log_file'
    
    There was 3 different things called log_file in this file: a global FileHandle,
    a local PathString, and a PathChar* member variable in LoggingSettings. :/
    
    (Should probably rename all the globals to g_ prefixed in a followup.)
    
    R=thakis@chromium.org
    BUG=440500
    
    Review URL: https://codereview.chromium.org/883853003
    
    Cr-Commit-Position: refs/heads/master@{#313364}
    fc5b7077
logging.cc 24.2 KB