• Nico Weber's avatar
    Remove _Printf_format_string_. · fc7c8dd8
    Nico Weber authored
    It was only used by MSVC which we no longer use, and it required
    including sal.h (somewhat large) in compiler_specific.h (somewhat
    commonly included).
    
    clang-cl now no longer needs to process sal.h, which will help
    with build times a tiny bit. We still get the format string
    protection through the PRINTF_FORMAT macro.
    
    (WPRINTF_FORMAT on the other hand is a no-op and clang-cl
    seems to not check wprintf style format strings. So we do
    lose some coverage here for wide strings, but we lost that
    when we switched to clang-cl.)
    
    TBR=slangley
    
    Bug: none
    Change-Id: Iab02869cb06682500ab31e1810c070708347ad64
    Reviewed-on: https://chromium-review.googlesource.com/c/1494679
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Auto-Submit: Nico Weber <thakis@chromium.org>
    Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#636549}
    fc7c8dd8
event_logger.h 2.26 KB