• Sunny Sachanandani's avatar
    gpu: Do not promote I420A video to overlay on Windows · fc9c6f0f
    Sunny Sachanandani authored
    GpuMemoryBufferVideoFramePool uses RGBA/BGRA as the output format for
    I420A video frames, and those are promoted to overlays on all platforms.
    This causes SwapBuffers to fail in the GPU process on Windows since the
    direct composition path can only handle YUV video.  This wasn't a
    problem until we started promoting TextureDrawQuads to overlays in
    crrev.com/c/1746796 assuming that the is_overlay_candidate flag would
    only be set for low latency canvas that uses a swap chain.
    
    A pixel test with yuva420p vp9 video is added.  The video was generated
    using the following ffmpeg command:
    
    ffmpeg -i four-colors.mp4 -filter_complex \
    "color=c=#7F7F7F7F:s=960x540:rate=12[a];[0][a]alphamerge,format=yuva420p" \
    -c:v libvpx-vp9 -auto-alt-ref 0 four-colors-vp9-i420a.webm
    
    Bug: 1005028
    Change-Id: Idc84d29c588cf3b9273fb605b2542be5441d61d7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829556
    Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    Reviewed-by: default avatarDaniele Castagna <dcastagna@chromium.org>
    Reviewed-by: default avatarFrank Liberato <liberato@chromium.org>
    Reviewed-by: default avatarZhenyao Mo <zmo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#702590}
    fc9c6f0f
README.md 40.5 KB