• Yao Xiao's avatar
    Mark the element on viewport resize disqualified to become overlay-popup-ad · fcb2adf4
    Yao Xiao authored
    - If there is a small overlay in the page (e.g. sticky ad on the side),
    and the user shrinks the viewport to make the overlay centered &
    relatively large, we don't want to consider it to be a "popup".
    - Changed all relevant tests to promise_test for better readability.
    - Removed most waitings in web_tests by disabling the frequency capping.
    - A bugfix: It was a no-op to compare last_detection_main_frame_size_
    and main_frame_size after setting them equal. This patch moves the
    setting after the comparison.
    - An improvement/fix: for the current overlay candidate, always check
    element->IsAdRelated() in each detection, and update its ad status if it
    becomes an ad.
    
    Bug: 1032681
    Change-Id: If1d945be69d51289cf3314b5700e265772f0087e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291211Reviewed-by: default avatarStefan Zager <szager@chromium.org>
    Commit-Queue: Yao Xiao <yaoxia@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#790113}
    fcb2adf4
SlowTests 38.1 KB