GitLab

The old code assumes children might need layout even when not invalid.  This was
originally added to fix http://crbug.com/8511 .  This seems like a bogus fix; if
the metrics of something in the nonclient area change in such a way that we
actually notice and make it to NonClientView::Layout(), we should have had an
opportunity to invalid child layouts as needed.  I suspect this doesn't actually
happen anymore (some of the rest of that bugfix is already gone), but if it does
we should fix in a different way.

This also reorders definitions to match declaration order, removes a bunch of
section-break comments that are atypical style nowadays, and adds some TODOs for
further refactoring.


Bug: none
Change-Id: Ib386921c85c43ee05473acf1ac1b660a68d28809
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823642
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712323}