GitLab

Apart from the build/tooling/test/third-party directories listed in
suppressions.xml, every usage of System#exit must be explicit and have
the @SuppressWarnings annotation, preferably with a short explanation of
why it is necessary.

Added @SuppressWarnings for all existing usages.

Removed the System#exit call in ChromeApplication since we have no
visibility into how often the application replacing bug is hit. Throwing
an exception with a custom message will help us see its current impact.

Bug: 1000651
Change-Id: Ia48598b32e339efccb0ca1b55ef03068da505410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851770
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#706426}