• Michael Ershov's avatar
    Revert "Propagate main frame document dimensions through frame intersections." · fd47d4d2
    Michael Ershov authored
    This reverts commit 2412286a.
    
    Reason for revert: Soon after this CL PageLoadMetricsBrowserTest.UseCounterFeaturesInNonSecureMainFrame and some other PageLoadMetricsBrowserTest* tests became flaky.
    
    Original change's description:
    > Propagate main frame document dimensions through frame intersections.
    > 
    > This change calls OnMainFrameDocumentIntersectionChanged for the main
    > frame. The RenderFrame resets the main frame's intersection when the
    > frame commits a navigation to ensure we propagate a new intersection
    > for each committed navigation (otherwise we may lose updates when the
    > render frame observer propagates values for uncommitted loads to
    > page load metrics).
    > 
    > This allows consumers to compare frame intersections with the main
    > frame's rect. This is a precursor to measuring page ad density.
    > 
    > BUG=993453
    > 
    > Change-Id: I689505c086ed0216af9f216ed4dd3d13f9c3ec1d
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105622
    > Commit-Queue: Justin Miron <justinmiron@google.com>
    > Reviewed-by: Robert Sesek <rsesek@chromium.org>
    > Reviewed-by: John Delaney <johnidel@chromium.org>
    > Reviewed-by: Stefan Zager <szager@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#754626}
    
    TBR=szager@chromium.org,rsesek@chromium.org,johnidel@chromium.org,justinmiron@google.com
    
    Change-Id: I560698131b66fc9cb2b6a33737ffde2016cd5636
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 993453, 1066455
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129533Reviewed-by: default avatarMichael Ershov <miersh@google.com>
    Commit-Queue: Michael Ershov <miersh@google.com>
    Cr-Commit-Position: refs/heads/master@{#754894}
    fd47d4d2
page_load_metrics.mojom 12.1 KB