• qsr@chromium.org's avatar
    [Telemetry] Fix page_cycler for pages with client side redirects. · fd51b8b0
    qsr@chromium.org authored
    Page.disable clears all scripts to evaluate on commit. There is no way
    to detect client side redirects because linkedin, for example, performs
    its client side redirect after the page has fully loaded.
    
    In order for the page_cyclers to work on pages with client side
    redirects, the script to evaluate on commit must execute on the
    redirected page.
    
    So to workaround this, we avoid ever calling Page.disable. we don't
    expect continuing to listen for notifications here to impact
    performance, but if we do see any performance reduction on the bots we
    should revert and search for another approach.
    
    This is a reland of https://codereview.chromium.org/103373003 fixing failures
    on the bots.
    
    BUG=253604
    R=pdr@chromium.org
    TEST=tools/perf/run_measurement --browser=canary page_cycler tools/perf/page_sets/top_10_mobile.json --pageset-repeat=2
    
    Review URL: https://codereview.chromium.org/112413006
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243533 0039d316-1c4b-4281-b951-d872f2087c98
    fd51b8b0
page_cycler.py 2.97 KB