• Mark Cogan's avatar
    [iOS] Clean up tab grid metrics · fd61abca
    Mark Cogan authored
    This CL cleans up tab grid metric names and regularizes how they are called.
    
    All tab grid metrics are now named "TabGrid*". "Regular" is used instead of "NonIncognito" in metric names. Straightforward renames are as follows:
    
    (All of the original names for these metrics were defined in the internal actions.xml file and will be obsoleted)
      MobileStackViewCloseTab -> MobileTabGridCloseControlTapped
      MobileTabSwitcherHeaderViewSelectDistantSessionPanel -> MobileTabGridSelectRemotePanel
      MobileTabSwitcherOpenNonIncognitoTab -> MobileTabGridOpenRegularTab
      MobileTabSwitcherOpenIncognitoTab -> MobileTabGridOpenIncognitoTab
      MobileTabSwitcherCloseNonIncognitoTab -> MobileTabGridCloseRegularTab
      MobileTabSwitcherCloseIncognitoTab -> MobileTabGridCloseIncognitoTab
      MobileTabReturnedToCurrentTab -> MobileTabGridDone
    
    (The original names for these metrics were not defined anywhere!)
      MobileTabSwitcherPresented -> MobileTabGridEntered
      MobileTabSwitcherDismissed -> MobileTabGridExited
    
    Some metrics that were tracked separately in the old stack view and table tab switcher are here consolidated into a single metric:
    
    MobileTabSwitcherHeaderViewSelectIncognitoPanel, MobileStackViewIncognitoMode -> MobileTabGridSelectIncognitoPanel
    MobileTabSwitcherHeaderViewSelectNonIncognitoPanel,  MobileStackViewNormalMode -> MobileTabGridSelectRegularPanel
    
    The metrics for tab creation are now separated to distinguish use of the new tab button and the keyboard shortcuts. The relevant code is also restructured for this.
    
      MobileTabSwitcherCreateNonIncognitoTab -> MobileTabGridCreateRegularTab, MobileTabGridCreateRegularTabKeyboard
      MobileTabSwitcherCreateIncognitoTab -> MobileTabGridCreateIncognitoTab, MobileTabGridCreateRegularTabKeyboard
    
    Bug: 856965
    Change-Id: I3d78e2bb27ce2db46a4b4e7a1c32017742fcc514
    Reviewed-on: https://chromium-review.googlesource.com/c/1475486
    Auto-Submit: Mark Cogan <marq@chromium.org>
    Commit-Queue: edchin <edchin@chromium.org>
    Reviewed-by: default avatarSteven Holte <holte@chromium.org>
    Reviewed-by: default avataredchin <edchin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#635745}
    fd61abca
actions.xml 780 KB