• Hans Wennborg's avatar
    Revert "Reland "win: Link with lld instead of MSVC's link.exe by default"" · fda7b0b6
    Hans Wennborg authored
    This reverts commit 6b5ac2ef.
    
    Reason for revert:
    It broke the Win ASan bot on the LKGR waterfall (see second bug).
    
    Original change's description:
    > Reland "win: Link with lld instead of MSVC's link.exe by default"
    > 
    > This is a reland of be8138a4
    > The issues with the previous attempt were addressed in the latest
    > Clang roll (#553415).
    > 
    > Original change's description:
    > > win: Link with lld instead of MSVC's link.exe by default
    > >
    > > lld is LLVM's linker. It produces PE/COFF and PDB files just like
    > > link.exe, but it's significantly faster and it can also handle LLVM's
    > > internal representation, which will enable us to do link-time
    > > optimization and control-flow integraty checks with Clang.
    > >
    > > While lld is much faster at linking, it doesn't support incremental
    > > links, meaning builds that only touch a few files and re-link a large
    > > executable may become slower.
    > >
    > > This is the first attempt at switching everything over, with the
    > > purpose of gathering data and finding unknown unknowns. It's likely
    > > temporary until something breaks.
    > >
    > > is_win_fastlink is implicitly ignored when using lld, as lld without
    > > fastlink is faster than link.exe with it.
    > >
    > > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's
    > > link.exe to make sure that configuration keeps working.
    > >
    > > Bug: 792131
    > > Change-Id: I0f115a78c33d69eadbd480f75c2a5d636e86483d
    > > Reviewed-on: https://chromium-review.googlesource.com/983632
    > > Commit-Queue: Nico Weber <thakis@chromium.org>
    > > Reviewed-by: Nico Weber <thakis@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#551367}
    > 
    > Bug: 792131
    > Change-Id: I3b76cd015ef18bb3e2ac7a3efa4352c4f04e560b
    > Reviewed-on: https://chromium-review.googlesource.com/1028374
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Commit-Queue: Hans Wennborg <hans@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#553776}
    
    TBR=thakis@chromium.org,hans@chromium.org
    
    Change-Id: Ied5addd2f8d16d1e002bf37846e7106b4c754cb9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 792131, 837090
    Reviewed-on: https://chromium-review.googlesource.com/1029631Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
    Commit-Queue: Hans Wennborg <hans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#553878}
    fda7b0b6
mb_config.pyl 74 KB