• Takashi Toyoshima's avatar
    OOR-CORS: Use net::ERR_ABORTED on OnConnectionError · fdf9d6d3
    Takashi Toyoshima authored
    Currently, some tests expect it does not complete, and others do
    returning net::ERR_ABORTED. But it's really tough to realize the
    same behavior when OutOfBlinkCORS is enabled because timing differs.
    
    With this fix, CORSURLLoader is changed to return net::ERR_ABORTED
    on OnConnectionError that happens when a client destructs a loader.
    
    Existing tests that expect it does not complete are also modified
    to check if it does not complete or it completes with the error.
    
    This patch will make tests below pass even with OutOfBlinkCORS enabled.
    - ResourceDispatcherHostTest.DataSentBeforeDetach
    - ResourceDispatcherHostTest.Cancel
    - ResourceDispatcherHostTest.DetachedResourceTimesOut
    - ResourceDispatcherHostTest.TestBlockedRequestsProcessDies
    - ResourceDispatcherHostTest.TestBlockingCancelingRequests
    
    Bug: 872634, 870173
    Cq-Include-Trybots: luci.chromium.try:linux_mojo
    Change-Id: I2f7f40de49d5820413eaf4e80debf747ba66632a
    Reviewed-on: https://chromium-review.googlesource.com/1230039Reviewed-by: default avatarYutaka Hirano <yhirano@chromium.org>
    Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#593836}
    fdf9d6d3
resource_dispatcher_host_unittest.cc 98.4 KB