GitLab

This reverts commit f00acd85.

Reason for revert: crbug.com/863795

Original change's description:
> Reland "overview: Hide title bars before animating into overview mode."
> 
> This is a reland of a663e7fd
> 
> The original cl causes some flaky tests with stack trace:
> 
> [16202:16202:0709/211202.910243:FATAL:single_thread_proxy.cc(237)] Check failed: task_runner_provider_->IsMainThread().
> #0 0x7f9b36f8672d base::debug::StackTrace::StackTrace()
> #1 0x7f9b36c9d3fc base::debug::StackTrace::StackTrace()
> #2 0x7f9b36d06dfd logging::LogMessage::~LogMessage()
> #3 0x7f9b2b5692e8 cc::SingleThreadProxy::SetNeedsCommit()
> #4 0x7f9b2b45ecef cc::LayerTreeHost::SetNeedsCommit()
> #5 0x7f9b2b467426 cc::LayerTreeHost::SetMutatorsNeedCommit()
> #6 0x7f9b0fd29981 cc::AnimationHost::SetNeedsCommit()
> #7 0x7f9b0fd1962d cc::Animation::SetNeedsCommit()
> #8 0x7f9b0fd41151 cc::KeyframeEffect::KeyframeModelAdded()
> #9 0x7f9b0fd44e6c cc::KeyframeEffect::AddKeyframeModel()
> #10 0x7f9b0fd17fbc cc::Animation::AddKeyframeModelForKeyframeEffect()
> #11 0x7f9b0fd71a6d cc::SingleKeyframeEffectAnimation::AddKeyframeModel()
> #12 0x7f9b28c83a95 ui::LayerAnimator::AddThreadedAnimation()
> #13 0x7f9b28c7498e ui::(anonymous namespace)::ThreadedLayerAnimationElement::RequestEffectiveStart()
> #14 0x7f9b28c71113 ui::LayerAnimationElement::Start()
> #15 0x7f9b28c7cbe3 ui::LayerAnimationSequence::Start()
> #16 0x7f9b28c84287 ui::LayerAnimator::StartSequenceImmediately()
> #17 0x7f9b28c81251 ui::LayerAnimator::StartAnimation()
> #18 0x7f9b28c80eb6 ui::LayerAnimator::SetTransform()
> #19 0x7f9b28c6122e ui::Layer::SetTransform()
> #20 0x7f9b28ded831 aura::Window::SetTransform()
> #21 0x7f9b22b732df ash::ScopedTransformOverviewWindow::SetTransform()
> #22 0x7f9b22b73f69 ash::ScopedTransformOverviewWindow::OnCompositingStarted()
> #23 0x7f9b28c4d734 ui::Compositor::DidSubmitCompositorFrame()
> #24 0x7f9b2b56cd05 cc::SingleThreadProxy::DoComposite()
> #25 0x7f9b2b56e835 cc::SingleThreadProxy::ScheduledActionDrawIfPossible()
> #26 0x7f9b2b3736fd cc::Scheduler::DrawIfPossible()
> #27 0x7f9b2b36dbdc cc::Scheduler::ProcessScheduledActions()
> #28 0x7f9b2b36d5fd cc::Scheduler::OnBeginImplFrameDeadline()
> 
> This cl makes that test skip waiting for composit when entering overview, like the tests
> in ash.
> 
> Original change's description:
> > overview: Hide title bars before animating into overview mode.
> >
> > The title bars should not visible while animating overview mode. This cl
> > hides the title bar if needed and waits until the next paint before
> > animating the windows. This will hide the title bar as expected while
> > keeping the benefits of DeferPaint.
> >
> > Test: manual
> > Bug: 843851
> > Change-Id: I99cf7ca39fd1ae14314ac406abd0fec999e2c024
> > Reviewed-on: https://chromium-review.googlesource.com/1112774
> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> > Reviewed-by: Tao Wu <wutao@chromium.org>
> > Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#573552}
> 
> TBR=oshima@chromium.org
> 
> Bug: 843851
> Change-Id: I3a538250d5f6d42d6c73e218445080af533b54dc
> Reviewed-on: https://chromium-review.googlesource.com/1131874
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574209}

TBR=msw@chromium.org,oshima@chromium.org,sammiequon@chromium.org,wutao@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 843851
Change-Id: Ib2744c7f677be40004b70a714cebe0a337f7c60b
Reviewed-on: https://chromium-review.googlesource.com/1142304Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576250}