• tfarina@chromium.org's avatar
    bookmarks: Fix mistakes found by cppcheck. · fe232e08
    tfarina@chromium.org authored
    bookmark_index_unittest.cc:
    Summary: Function parameter 'expected_titles' should be passed by reference.
    Message: Parameter 'expected_titles' is passed as a value. It could be passed as a (const) reference which is usually faster and recommended in C++.
    
    bookmark_model_unittest.cc:
    Summary: Member variable 'BookmarkModelTestWithProfile::bb_model_' is not initialized in the constructor.
    Message: Member variable 'BookmarkModelTestWithProfile::bb_model_' is not initialized in the constructor.
    
    R=sky@chromium.org
    
    Review URL: https://chromiumcodereview.appspot.com/10828168
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150346 0039d316-1c4b-4281-b951-d872f2087c98
    fe232e08
bookmark_model_unittest.cc 41.4 KB