GitLab

This reverts commit 0830cdf0.

Reason for revert: UX direction change.

Original change's description:
> Omnibox UI Refresh: Align Omnibox text to new Suggestion text
> 
> The goal of the CL is to re-align the Omnibox text to match the new
> Refresh spec.
> 
> In the new Refresh spec, the text has a different indentation depending
> on whether or not the popup is open, so this CL resets the insets
> of the OmniboxViewViews whenever the popup opens or closes.
> 
> It also updates LocationBarView to no longer ignore the left-inset
> value of the OmniboxViewViews. We used to also ignore the right-inset
> value, but we stopped doing that recently [1].
> 
> After no longer ignoring the left-inset value, we update the
> non-Refresh value to the correct value of 0 (to keep things looking
> the same), and update the Refresh value to 2, which matches mocks.
> 
> We are updating the inset of the OmniboxViewViews textfield instead of
> the bounds of the textfield because we want the whole area to remain a
> clickable I-beam, even if we indent the text a bit.
> 
> [1] https://codereview.chromium.org/2642893002/diff/100001/chrome/browser/ui/views/location_bar/location_bar_view.cc
> 
> Bug: 849779, 823535
> Change-Id: I8c2a9e4934a78efec0d3d6cd60c63181be2d92c4
> Reviewed-on: https://chromium-review.googlesource.com/1096491
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
> Commit-Queue: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566834}

TBR=sky@chromium.org,tommycli@chromium.org,jdonnelly@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 849779, 823535
Change-Id: Icf9e2f004042be6f25b9a86d23f269f5ebf0fd90
Reviewed-on: https://chromium-review.googlesource.com/1117218
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570847}