• kylechar's avatar
    Revert "[gpu] Add trace events and thread priority assertion in GpuChannelHost." · fe6e8407
    kylechar authored
    This reverts commit 0b7197a2.
    
    Reason for revert: Speculative revert for https://crbug.com/1145587
    
    Original change's description:
    > [gpu] Add trace events and thread priority assertion in GpuChannelHost.
    >
    > Traces collected through Slow Reports show that acquiring the
    > GpuChannelHost lock from threads running at different priorities can
    > cause priority inversions. In particular, it can cause jank on the
    > renderer main thread through this chain of dependency:
    >
    > > Main thread: cc::ProxyMain::BeginMainFrame
    >   > Compositor Thread: TileManager::FlushAndIssueSignals
    >     > CompositorTileWorkerBackground (slow):
    >         OneCopyRasterBuffer::Playback
    >
    > This CL adds trace events to make contention on the GpuChannelHost lock
    > more obvious in traces, and an assertion to ensure that the
    > GpuChannelHost lock is never acquired at background thread priority.
    >
    > Bug: 1072756
    > Change-Id: I2a25efe2e3f6e9bf5d980ca351a990f9c7d256b4
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157659
    > Commit-Queue: François Doray <fdoray@chromium.org>
    > Reviewed-by: Victor Miura <vmiura@chromium.org>
    > Auto-Submit: François Doray <fdoray@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#823744}
    
    TBR=fdoray@chromium.org,vmiura@chromium.org
    
    Change-Id: I18717e6387e20e892b2a58e1aad34cd8b5e4d3e9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1072756, 1145587
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519397Reviewed-by: default avatarkylechar <kylechar@chromium.org>
    Commit-Queue: kylechar <kylechar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#824017}
    fe6e8407
gpu_channel_host.cc 13.5 KB