• Maxim Kolosovskiy's avatar
    [Password Generation] Hot fix for a crash in PasswordGenerationAgent · fe9d0eac
    Maxim Kolosovskiy authored
    |(element.Form() == generation_element_.Form())| in PasswordGenerationAgent::TextDidChangeInTextField causes a crash. |element| or |generation_element_| is null.
    
    Probable reason: That code assumes that |generation_element_| must be non-null if |password_is_generated_| is true. But in PasswordGenerationAgent::DidCommitProvisionalLoad, |generation_element_| is cleared while |password_is_generated_| stays the same. So, it is possible that |generation_element_| is null while |password_is_generated_| is true.
    
    TBR=dvadym@, vasilii@, ioanap@
    Bug: 879713
    
    Change-Id: I4b8a42ab8aebb1474f7a3b57c9fa63ab15dcd610
    Reviewed-on: https://chromium-review.googlesource.com/1200642
    Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
    Reviewed-by: default avatarMaxim Kolosovskiy <kolos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#588277}
    fe9d0eac
password_generation_agent.cc 29 KB