GitLab

This reverts commit 87182d18.

Reason for revert: Breaks browser_tests and viz_browser_tests.

Example:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/28716

Triggers DCHECK on line 859:
https://chromium.googlesource.com/chromium/src/+blame/87182d18c9a56d1860288e4e92e726e1f399bf97/chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc#859


Original change's description:
> Avoid conversion between GURL and std::string
> 
> ProfileDownloader::GetProfilePictureURL returns a std::string
> corresponding to the representation of a GURL then immediately
> converts it back to a GURL.
> 
> This is wasteful, so convert this method to return a GURL
> instead and convert GetCachedPictureURL to also cache the
> GURL instead of the string representation.
> 
> Convert static std::string to static char[] and use EXPECT_
> instead of ASSERT_ macros when possible in unit tests (since
> the EXPECT_ macro do not stop the test in case of failure).
> 
> Bug: none
> Change-Id: Ibe73f28b38b2061b37cbdb0b9b0696b25ca8c41c
> Reviewed-on: https://chromium-review.googlesource.com/1160645
> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
> Reviewed-by: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585426}

TBR=bauerb@chromium.org,msarda@chromium.org,sdefresne@chromium.org,jdufault@chromium.org

Change-Id: Ib1cc81bef47d279214f63528e78d4d885a7aa0e5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/1186761Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585477}