• Kenneth Russell's avatar
    Revert "Refactor subresource redirect renderer code" · ff1d9dd5
    Kenneth Russell authored
    This reverts commit 674a1af2.
    
    Reason for revert: suspected cause of crbug.com/1146687
    
    Original change's description:
    > Refactor subresource redirect renderer code
    >
    > This CL refactors the existing subresource redirect code to make the
    > robots rules and login based image compression implementation easy.
    >
    > * Separate out the url loader throttle that does redirect and timeout
    > handling from the public image hints decider logic. The robots decider can
    > be subclassed and used.
    >
    > * Make public image hints agent as renderframeobserver. This reduces
    > cluttter in ResourceLoadingHintsAgent. The upcoming robots checker agent
    > could also observe renderframeobserver directly.
    >
    > No change in behavior is expected.
    >
    > Change-Id: Ic555a4402016a645b8820fa87dd5157c7112fb71
    > Bug: 1144836
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514068
    > Commit-Queue: rajendrant <rajendrant@chromium.org>
    > Reviewed-by: Michael Crouse <mcrouse@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#825115}
    
    TBR=rajendrant@chromium.org,mcrouse@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1144836, 1146687
    Change-Id: I483882b29ac342d188137690e7ba9f8cbedcd6ee
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527859Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
    Commit-Queue: Kenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#825966}
    ff1d9dd5
BUILD.gn 390 KB