• David Bokan's avatar
    Revert "Add CHECKs to debug crash" · ff334c18
    David Bokan authored
    This reverts commit ffff10c5.
    
    Reason for revert: Temporary CL served it's purpose. ScrollNodes marked as inner_viewport aren't the same as InnerViewportScrollNode.
    
    Original change's description:
    > Add CHECKs to debug crash
    > 
    > It looks like this crashes because of a null outer viewport scroll node.
    > That should never happen here because we have an inner viewport scroll
    > node.
    > 
    > There's a few ways this could be going wrong:
    > 
    > - A ScrollNode is marked as the inner scroll node even though it wasn't
    >   registered as one in viewport_property_ids_
    > - The ScrollNode doesn't exist in the property tree even though it was
    >   registered.
    > - We're getting this bad combination from Blink.
    > 
    > I've turned a few DCHECKs into release CHECKs to narrow down which of
    > these it might be.
    > 
    > Bug: 1037759
    > Change-Id: I972582da6e18725557859063da0889d465063c77
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981268
    > Commit-Queue: David Bokan <bokan@chromium.org>
    > Auto-Submit: David Bokan <bokan@chromium.org>
    > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#728220}
    
    TBR=wangxianzhu@chromium.org,bokan@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1037759
    Change-Id: I64811d9a30b6ba98b395f6e4ea434958afa0b706
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006248Reviewed-by: default avatarDavid Bokan <bokan@chromium.org>
    Commit-Queue: David Bokan <bokan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#732654}
    ff334c18
layer_tree_host.cc 64.1 KB