• Sergio Collazos's avatar
    Revert "Password settings on iOS: use Title Case" · ff9611dd
    Sergio Collazos authored
    This reverts commit fd8b83c8.
    
    Reason for revert: This CL breaks password_settings_eg_test, we might need to update the tests so they use the new A11y labels. Though I'm not sure if there's more than that. 
    
    Original change's description:
    > Password settings on iOS: use Title Case
    > 
    > Most of setting headers in the passwords seciton on iOS already use Title Case,
    > except for the headers of the saved and blacklisted lists of passwords.
    > 
    > This CL fixes that by creating new strings for iOS settings inside
    > ios/chrome/app/strings/ios_strings.grd. Previously the code used shared strings
    > from the password_manager component (components/password_manager_strings.grdp).
    > That string was also used by the old (non-MD) desktop settings, which have
    > already been deprecated. The MD settings on desktop use the Title Case as iOS
    > should as well, but the MD settings strings are consistently saved in
    > chrome/app/settings_strings.grdp, where they cannot be shared with iOS.
    > 
    > The CL creates the new string instead of sharing the one from MD settings,
    > because sharing has no benefit (on no build both strings are included, so no
    > storage spared) and has the drawback of binding the style of both strings
    > forever together.
    > 
    > The CL does not remove the component string yet. The old desktop settings code
    > is still in the codebase, and the shared string (used only by the old settings)
    > should be deleted once those old settings are deleted.
    > 
    > The CL was approved in https://chromium-review.googlesource.com/c/567181. This
    > is a verbatim copy of that CL, but re-uploaded after Gerrit issues prevented me
    > to actually land the original one. Hence I'm TBR-in lpromero@ who approved the
    > original.
    > TBR=lpromero@chromium.org
    > 
    > Bug: 740952
    > Change-Id: I455b8f2a5edd1089916a7b87f20eddc3b274a2b7
    > Reviewed-on: https://chromium-review.googlesource.com/567930
    > Reviewed-by: Vaclav Brozek <vabr@chromium.org>
    > Commit-Queue: Vaclav Brozek <vabr@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#485912}
    
    TBR=vabr@chromium.org,lpromero@chromium.org
    
    Change-Id: I41a5e01b086a1643a6f72f3934d5cfea6ceb57b6
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 740952
    Reviewed-on: https://chromium-review.googlesource.com/568387Reviewed-by: default avatarSergio Collazos <sczs@chromium.org>
    Commit-Queue: Sergio Collazos <sczs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#485997}
    ff9611dd
ios_strings.grd 112 KB