• Elly Fong-Jones's avatar
    Revert "views: close menus when accelerators are pressed on Mac" · ffa48f01
    Elly Fong-Jones authored
    This reverts commit b3bf64e2.
    
    Reason for revert: Introduces https://crbug.com/906075 - bare command press closes menus
    
    Original change's description:
    > views: close menus when accelerators are pressed on Mac
    > 
    > This change:
    > 
    > 1) Has MenuController consider command to be an accelerator key, along with
    >    control and alt, for the purpose of not searching for mnemonics;
    > 2) Adds a Mac override of ViewsDelegate::ProcessAcceleratorWhileMenuShowing
    >    which tells the menu to close for an accelerator
    > 
    > Bug: 885138
    > Change-Id: Iee9d9abb3b1bb3c2d346d7aaf7e532866b4ad26a
    > Reviewed-on: https://chromium-review.googlesource.com/c/1334147
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#607699}
    
    TBR=ellyjones@chromium.org,sky@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 885138
    Change-Id: If98c70bcab18df7bd4895cbbc603c1878ba9ef91
    Reviewed-on: https://chromium-review.googlesource.com/c/1341218Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#609294}
    ffa48f01
chrome_views_delegate_mac.cc 677 Bytes