Commit 000a3068 authored by Mikel Astiz's avatar Mikel Astiz Committed by Commit Bot

Fix and reenable TwoClientPreferencesSyncTest.Sanity_E2ETest

The test has no control over production code changing preferences and
these changes being sync-ed too. Hence, let's relax the requirements and
verify that at least one UMA metric is emitted.

TBR=treib@chromium.org

Bug: 988404
Change-Id: Iaeb1907935ef040ab81967c4061075198e7b6d31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731490Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683278}
parent 32cbb022
...@@ -44,9 +44,7 @@ class TwoClientPreferencesSyncTest : public SyncTest { ...@@ -44,9 +44,7 @@ class TwoClientPreferencesSyncTest : public SyncTest {
DISALLOW_COPY_AND_ASSIGN(TwoClientPreferencesSyncTest); DISALLOW_COPY_AND_ASSIGN(TwoClientPreferencesSyncTest);
}; };
// TODO(crbug.com/988404): Enable once not flaky anymore. IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest, E2E_ENABLED(Sanity)) {
IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest,
E2E_ENABLED(DISABLED_Sanity)) {
DisableVerifier(); DisableVerifier();
ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
// Wait until sync settles before we override the prefs below. // Wait until sync settles before we override the prefs below.
...@@ -71,8 +69,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest, ...@@ -71,8 +69,8 @@ IN_PROC_BROWSER_TEST_F(TwoClientPreferencesSyncTest,
"Sync.ModelTypeEntityChange3.PREFERENCE", "Sync.ModelTypeEntityChange3.PREFERENCE",
/*REMOTE_NON_INITIAL_UPDATE=*/4)); /*REMOTE_NON_INITIAL_UPDATE=*/4));
EXPECT_EQ( EXPECT_NE(
1U, histogram_tester 0U, histogram_tester
.GetAllSamples( .GetAllSamples(
"Sync.NonReflectionUpdateFreshnessPossiblySkewed2.PREFERENCE") "Sync.NonReflectionUpdateFreshnessPossiblySkewed2.PREFERENCE")
.size()); .size());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment