Commit 0018e51a authored by Clemens Arbesser's avatar Clemens Arbesser Committed by Commit Bot

Changed snackbar message for stopping autobot to 'Autofill Assistant stopping'

The previous message contained the duration, which was confusing because the message was static and did not change while the timer was running. However, implementing a changing countdown message is somewhat tricky and not directly supported by snackbars. This change is a UI workaround to avoid this confusion.

Bug: 806868
Change-Id: I6d7a0c98545741341df2f8200acc49c4ebf776dd
Reviewed-on: https://chromium-review.googlesource.com/c/1331393Reviewed-by: default avatarStephane Zermatten <szermatt@chromium.org>
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#607575}
parent f0cab69f
...@@ -165,8 +165,7 @@ public class AutofillAssistantUiController implements AutofillAssistantUiDelegat ...@@ -165,8 +165,7 @@ public class AutofillAssistantUiController implements AutofillAssistantUiDelegat
@Override @Override
public void onDismiss() { public void onDismiss() {
mUiDelegateHolder.dismiss(R.string.autofill_assistant_stopped, mUiDelegateHolder.dismiss(R.string.autofill_assistant_stopped);
AutofillAssistantUiDelegate.SNACKBAR_DELAY_MS / 1_000);
} }
@Override @Override
......
...@@ -3929,8 +3929,8 @@ However, you aren’t invisible. Going private doesn’t hide your browsing from ...@@ -3929,8 +3929,8 @@ However, you aren’t invisible. Going private doesn’t hide your browsing from
<message name="IDS_AUTOFILL_ASSISTANT_ONBOARDING_TITLE" desc="Onboarding title for the autofill assistant."> <message name="IDS_AUTOFILL_ASSISTANT_ONBOARDING_TITLE" desc="Onboarding title for the autofill assistant.">
Fast checkout Fast checkout
</message> </message>
<message name="IDS_AUTOFILL_ASSISTANT_STOPPED" desc="Text label that is shown when stopping the Autofill Assistant. DURATION_SECONDS is a number representing a duration in seconds, which is why it is appended with 's'."> <message name="IDS_AUTOFILL_ASSISTANT_STOPPED" desc="Text label that is shown when stopping the Autofill Assistant.">
Autofill Assistant will stop in <ph name="DURATION_SECONDS">%1$s<ex>3</ex></ph>s… Autofill Assistant stopping
</message> </message>
<message name="IDS_INIT_OK" desc="Init screen confirmation text."> <message name="IDS_INIT_OK" desc="Init screen confirmation text.">
Let's go Let's go
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment