Commit 001e0ef2 authored by Milica Selakovic's avatar Milica Selakovic Committed by Commit Bot

[Autobot][Password change] Use canonical url as signon_realm value when creating form

Login.origin can contain additional data, like queries or username.
signon_realm needs to be canonical url.

Bug: 1064264
Change-Id: I78eacff5bc958887e230586330ded6d9215c45db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220027Reviewed-by: default avatarClemens Arbesser <arbesser@google.com>
Reviewed-by: default avatarMohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Milica Selakovic <selakovic@google.com>
Cr-Commit-Position: refs/heads/master@{#774090}
parent 4eee45bf
...@@ -190,6 +190,7 @@ jumbo_static_library("browser") { ...@@ -190,6 +190,7 @@ jumbo_static_library("browser") {
"//components/autofill_assistant/browser/devtools", "//components/autofill_assistant/browser/devtools",
"//components/google/core/common:common", "//components/google/core/common:common",
"//components/password_manager/core/browser:browser", "//components/password_manager/core/browser:browser",
"//components/password_manager/core/browser/form_parsing:form_parsing",
"//components/signin/public/identity_manager", "//components/signin/public/identity_manager",
"//components/strings:components_strings_grit", "//components/strings:components_strings_grit",
"//components/version_info", "//components/version_info",
......
...@@ -7,6 +7,7 @@ ...@@ -7,6 +7,7 @@
#include "base/stl_util.h" #include "base/stl_util.h"
#include "base/strings/utf_string_conversions.h" #include "base/strings/utf_string_conversions.h"
#include "components/password_manager/core/browser/form_fetcher_impl.h" #include "components/password_manager/core/browser/form_fetcher_impl.h"
#include "components/password_manager/core/browser/form_parsing/form_parser.h"
#include "components/password_manager/core/browser/password_form_metrics_recorder.h" #include "components/password_manager/core/browser/password_form_metrics_recorder.h"
#include "components/password_manager/core/browser/password_generation_frame_helper.h" #include "components/password_manager/core/browser/password_generation_frame_helper.h"
#include "components/password_manager/core/browser/password_manager_client.h" #include "components/password_manager/core/browser/password_manager_client.h"
...@@ -26,8 +27,8 @@ autofill::PasswordForm CreatePasswordForm( ...@@ -26,8 +27,8 @@ autofill::PasswordForm CreatePasswordForm(
const WebsiteLoginManager::Login& login, const WebsiteLoginManager::Login& login,
const std::string& password) { const std::string& password) {
autofill::PasswordForm form; autofill::PasswordForm form;
form.signon_realm = login.origin.spec();
form.url = login.origin.GetOrigin(); form.url = login.origin.GetOrigin();
form.signon_realm = password_manager::GetSignonRealm(form.url);
form.username_value = base::UTF8ToUTF16(login.username); form.username_value = base::UTF8ToUTF16(login.username);
form.password_value = base::UTF8ToUTF16(password); form.password_value = base::UTF8ToUTF16(password);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment