Commit 004070c0 authored by Andrew Luo's avatar Andrew Luo Committed by Commit Bot

Avoid silently using the wrong flags file for apk-under-test.

Bug: 996501
Change-Id: I664ebb130f949b9f4ccb0c24fd760c56db8cb0de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764869
Commit-Queue: Andrew Luo <aluo@chromium.org>
Reviewed-by: default avatarBen Pastene <bpastene@chromium.org>
Reviewed-by: default avatarJohn Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#690013}
parent 26b28368
...@@ -67,6 +67,10 @@ PACKAGE_INFO.update({ ...@@ -67,6 +67,10 @@ PACKAGE_INFO.update({
chrome.PackageInfo('com.android.webview', chrome.PackageInfo('com.android.webview',
'com.android.cts.webkit.WebViewStartupCtsActivity', 'com.android.cts.webkit.WebViewStartupCtsActivity',
'webview-command-line', None), 'webview-command-line', None),
'android_google_webview_cts':
chrome.PackageInfo('com.google.android.webview',
'com.android.cts.webkit.WebViewStartupCtsActivity',
'webview-command-line', None),
}) })
......
...@@ -398,9 +398,8 @@ class LocalDeviceInstrumentationTestRun( ...@@ -398,9 +398,8 @@ class LocalDeviceInstrumentationTestRun(
if self._test_instance.package_info: if self._test_instance.package_info:
cmdline_file = self._test_instance.package_info.cmdline_file cmdline_file = self._test_instance.package_info.cmdline_file
else: else:
logging.warning( raise Exception('No PackageInfo found but'
'No PackageInfo found, falling back to using flag file %s', '--use-apk-under-test-flags-file is specified.')
cmdline_file)
self._flag_changers[str(device)] = flag_changer.FlagChanger( self._flag_changers[str(device)] = flag_changer.FlagChanger(
device, cmdline_file) device, cmdline_file)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment