Commit 0046763d authored by Will Chen's avatar Will Chen Committed by Commit Bot

DevTools: deflake http/tests/devtools/indexeddb/delete-entry.js

This test is quite flaky because it was unintentionally dumping an internal
object property that's unstable between runs instead of the actual object contents.

Drive-by: removes extraneous method definition for ApplicationTestRunner.addIDBValueAsync

Bug: none
Change-Id: I749bb2d1379aa0658e590caeb9cd6d6773c59021
Reviewed-on: https://chromium-review.googlesource.com/846253Reviewed-by: default avatarEugene Ostroukhov <eostroukhov@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526610}
parent f72d9010
......@@ -6,16 +6,16 @@ Dumping IndexedDB tree:
Index: index1
Dumping ObjectStore data:
Object store: objectStore1
Key = testKey1, value = {"injectedScriptId":2,"id":1}
Key = testKey2, value = {"injectedScriptId":2,"id":2}
Key = testKey1, value = [{"name":"test","type":"string","value":"testKey1"},{"name":"testValue","type":"string","value":"testValue"}]
Key = testKey2, value = [{"name":"test","type":"string","value":"testKey2"},{"name":"testValue","type":"string","value":"testValue"}]
Index: index1
Key = testKey1, value = {"injectedScriptId":2,"id":3}
Key = testKey2, value = {"injectedScriptId":2,"id":4}
Key = testKey1, value = [{"name":"test","type":"string","value":"testKey1"},{"name":"testValue","type":"string","value":"testValue"}]
Key = testKey2, value = [{"name":"test","type":"string","value":"testKey2"},{"name":"testValue","type":"string","value":"testValue"}]
Dumping ObjectStore data:
Object store: objectStore1
Key = testKey2, value = {"injectedScriptId":2,"id":5}
Key = testKey2, value = [{"name":"test","type":"string","value":"testKey2"},{"name":"testValue","type":"string","value":"testValue"}]
Index: index1
Key = testKey2, value = {"injectedScriptId":2,"id":6}
Key = testKey2, value = [{"name":"test","type":"string","value":"testKey2"},{"name":"testValue","type":"string","value":"testValue"}]
Dumping ObjectStore data:
Object store: objectStore1
Index: index1
......
......@@ -12,7 +12,7 @@
TestRunner.addResult(` Index: ${treeElement.title}`);
treeElement.select();
for (var entry of treeElement._view._entries)
TestRunner.addResult(` Key = ${entry.primaryKey.value}, value = ${entry.value.objectId}`);
TestRunner.addResult(` Key = ${entry.primaryKey.value}, value = ${JSON.stringify(entry.value.preview.properties)}`);
}
function dumpObjectStores() {
......@@ -22,7 +22,7 @@
objectStoreTreeElement.select();
TestRunner.addResult(` Object store: ${objectStoreTreeElement.title}`);
for (var entry of objectStoreTreeElement._view._entries)
TestRunner.addResult(` Key = ${entry.key.value}, value = ${entry.value.objectId}`);
TestRunner.addResult(` Key = ${entry.key.value}, value = ${JSON.stringify(entry.value.preview.properties)}`);
for (var treeElement of objectStoreTreeElement.children())
dumpObjectStore(treeElement);
}
......
......@@ -175,11 +175,6 @@ ApplicationTestRunner.addIDBValueAsync = function(databaseName, objectStoreName,
'addIDBValueAsync(\'' + databaseName + '\', \'' + objectStoreName + '\', \'' + key + '\', \'' + value + '\')');
};
ApplicationTestRunner.addIDBValueAsync = function(databaseName, objectStoreName, key, value) {
return TestRunner.evaluateInPageAsync(
'addIDBValueAsync(\'' + databaseName + '\', \'' + objectStoreName + '\', \'' + key + '\', \'' + value + '\')');
};
ApplicationTestRunner.deleteIDBValueAsync = function(databaseName, objectStoreName, key) {
return TestRunner.evaluateInPageAsync(
'deleteIDBValueAsync(\'' + databaseName + '\', \'' + objectStoreName + '\', \'' + key + '\')');
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment