Commit 0062f525 authored by Alex Hawker's avatar Alex Hawker Committed by Commit Bot

[Bento] Adds a new flag for the Bento feature

Adds a new chrome://flags entry to enable the offline Bento
experience feature.

Bug: 1110112
Change-Id: I73cec4264465711f0e98c0b8c8b5d54013e83257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321342Reviewed-by: default avatarDonn Denman <donnd@chromium.org>
Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Commit-Queue: Alex Hawker <ahawker@google.com>
Cr-Commit-Position: refs/heads/master@{#792881}
parent 31be6fd2
...@@ -2337,6 +2337,9 @@ const FeatureEntry kFeatureEntries[] = { ...@@ -2337,6 +2337,9 @@ const FeatureEntry kFeatureEntries[] = {
{"related-searches", flag_descriptions::kRelatedSearchesName, {"related-searches", flag_descriptions::kRelatedSearchesName,
flag_descriptions::kRelatedSearchesDescription, kOsAndroid, flag_descriptions::kRelatedSearchesDescription, kOsAndroid,
FEATURE_VALUE_TYPE(chrome::android::kRelatedSearches)}, FEATURE_VALUE_TYPE(chrome::android::kRelatedSearches)},
{"bento-offline", flag_descriptions::kBentoOfflineName,
flag_descriptions::kBentoOfflineDescription, kOsAndroid,
FEATURE_VALUE_TYPE(chrome::android::kBentoOffline)},
#endif // OS_ANDROID #endif // OS_ANDROID
{"show-autofill-type-predictions", {"show-autofill-type-predictions",
flag_descriptions::kShowAutofillTypePredictionsName, flag_descriptions::kShowAutofillTypePredictionsName,
......
...@@ -396,6 +396,11 @@ ...@@ -396,6 +396,11 @@
"owners": [ "sorin", "waffles", "tiborg" ], "owners": [ "sorin", "waffles", "tiborg" ],
"expiry_milestone": 76 "expiry_milestone": 76
}, },
{
"name": "bento-offline",
"owners": [ "ahawker@google.com", "donnd" ],
"expiry_milestone": 89
},
{ {
"name": "block-external-form-redirects-no-gesture", "name": "block-external-form-redirects-no-gesture",
"owners": [ "jochen", "tedchoc" ], "owners": [ "jochen", "tedchoc" ],
......
...@@ -2540,6 +2540,11 @@ const char kBackgroundTaskComponentUpdateName[] = ...@@ -2540,6 +2540,11 @@ const char kBackgroundTaskComponentUpdateName[] =
const char kBackgroundTaskComponentUpdateDescription[] = const char kBackgroundTaskComponentUpdateDescription[] =
"Schedule component updates with BackgroundTaskScheduler"; "Schedule component updates with BackgroundTaskScheduler";
const char kBentoOfflineName[] =
"Enables an experiment for Offline Bento content on Android";
const char kBentoOfflineDescription[] =
"Enables displaying Bento content on the offline page for Android.";
const char kCCTIncognitoName[] = "Chrome Custom Tabs Incognito mode"; const char kCCTIncognitoName[] = "Chrome Custom Tabs Incognito mode";
const char kCCTIncognitoDescription[] = const char kCCTIncognitoDescription[] =
"Enables incognito mode for Chrome Custom Tabs, on Android."; "Enables incognito mode for Chrome Custom Tabs, on Android.";
......
...@@ -1467,6 +1467,9 @@ extern const char kAutofillUseMobileLabelDisambiguationDescription[]; ...@@ -1467,6 +1467,9 @@ extern const char kAutofillUseMobileLabelDisambiguationDescription[];
extern const char kBackgroundTaskComponentUpdateName[]; extern const char kBackgroundTaskComponentUpdateName[];
extern const char kBackgroundTaskComponentUpdateDescription[]; extern const char kBackgroundTaskComponentUpdateDescription[];
extern const char kBentoOfflineName[];
extern const char kBentoOfflineDescription[];
extern const char kCCTIncognitoName[]; extern const char kCCTIncognitoName[];
extern const char kCCTIncognitoDescription[]; extern const char kCCTIncognitoDescription[];
......
...@@ -109,6 +109,7 @@ const base::Feature* kFeaturesExposedToJava[] = { ...@@ -109,6 +109,7 @@ const base::Feature* kFeaturesExposedToJava[] = {
&kAndroidPartnerCustomizationPhenotype, &kAndroidPartnerCustomizationPhenotype,
&kAndroidPayIntegrationV2, &kAndroidPayIntegrationV2,
&kAndroidSearchEngineChoiceNotification, &kAndroidSearchEngineChoiceNotification,
&kBentoOffline,
&kCastDeviceFilter, &kCastDeviceFilter,
&kCloseTabSuggestions, &kCloseTabSuggestions,
&kCCTBackgroundTab, &kCCTBackgroundTab,
...@@ -310,6 +311,9 @@ const base::Feature kAndroidSearchEngineChoiceNotification{ ...@@ -310,6 +311,9 @@ const base::Feature kAndroidSearchEngineChoiceNotification{
const base::Feature kBackgroundTaskComponentUpdate{ const base::Feature kBackgroundTaskComponentUpdate{
"BackgroundTaskComponentUpdate", base::FEATURE_DISABLED_BY_DEFAULT}; "BackgroundTaskComponentUpdate", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kBentoOffline{"BentoOffline",
base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature kConditionalTabStripAndroid{ const base::Feature kConditionalTabStripAndroid{
"ConditionalTabStripAndroid", base::FEATURE_DISABLED_BY_DEFAULT}; "ConditionalTabStripAndroid", base::FEATURE_DISABLED_BY_DEFAULT};
......
...@@ -22,6 +22,7 @@ extern const base::Feature kAndroidPartnerCustomizationPhenotype; ...@@ -22,6 +22,7 @@ extern const base::Feature kAndroidPartnerCustomizationPhenotype;
extern const base::Feature kAndroidPayIntegrationV2; extern const base::Feature kAndroidPayIntegrationV2;
extern const base::Feature kAndroidSearchEngineChoiceNotification; extern const base::Feature kAndroidSearchEngineChoiceNotification;
extern const base::Feature kBackgroundTaskComponentUpdate; extern const base::Feature kBackgroundTaskComponentUpdate;
extern const base::Feature kBentoOffline;
extern const base::Feature kCloseTabSuggestions; extern const base::Feature kCloseTabSuggestions;
extern const base::Feature kCastDeviceFilter; extern const base::Feature kCastDeviceFilter;
extern const base::Feature kCCTBackgroundTab; extern const base::Feature kCCTBackgroundTab;
......
...@@ -220,6 +220,7 @@ public abstract class ChromeFeatureList { ...@@ -220,6 +220,7 @@ public abstract class ChromeFeatureList {
public static final String AUTOFILL_KEYBOARD_ACCESSORY = "AutofillKeyboardAccessory"; public static final String AUTOFILL_KEYBOARD_ACCESSORY = "AutofillKeyboardAccessory";
public static final String BACKGROUND_TASK_SCHEDULER_FOR_BACKGROUND_SYNC = public static final String BACKGROUND_TASK_SCHEDULER_FOR_BACKGROUND_SYNC =
"BackgroundTaskSchedulerForBackgroundSync"; "BackgroundTaskSchedulerForBackgroundSync";
public static final String BENTO_OFFLINE = "BentoOffline";
public static final String BIOMETRIC_TOUCH_TO_FILL = "BiometricTouchToFill"; public static final String BIOMETRIC_TOUCH_TO_FILL = "BiometricTouchToFill";
public static final String CAPTIVE_PORTAL_CERTIFICATE_LIST = "CaptivePortalCertificateList"; public static final String CAPTIVE_PORTAL_CERTIFICATE_LIST = "CaptivePortalCertificateList";
public static final String CCT_BACKGROUND_TAB = "CCTBackgroundTab"; public static final String CCT_BACKGROUND_TAB = "CCTBackgroundTab";
......
...@@ -40155,6 +40155,7 @@ from previous Chrome versions. ...@@ -40155,6 +40155,7 @@ from previous Chrome versions.
<int value="-1715180530" <int value="-1715180530"
label="OmniboxUIExperimentShowSuffixOnAllSearchSuggestions:disabled"/> label="OmniboxUIExperimentShowSuffixOnAllSearchSuggestions:disabled"/>
<int value="-1714128884" label="disable-launcher-search-provider-api"/> <int value="-1714128884" label="disable-launcher-search-provider-api"/>
<int value="-1713602121" label="BentoOffline:enabled"/>
<int value="-1713564656" label="ProtectSyncCredentialOnReauth:enabled"/> <int value="-1713564656" label="ProtectSyncCredentialOnReauth:enabled"/>
<int value="-1711751318" label="enable-data-reduction-proxy-lo-fi-preview"/> <int value="-1711751318" label="enable-data-reduction-proxy-lo-fi-preview"/>
<int value="-1710772665" label="disable-my-files-navigation"/> <int value="-1710772665" label="disable-my-files-navigation"/>
...@@ -40961,6 +40962,7 @@ from previous Chrome versions. ...@@ -40961,6 +40962,7 @@ from previous Chrome versions.
label="kAutofillRationalizeRepeatedServerPredictions:disabled"/> label="kAutofillRationalizeRepeatedServerPredictions:disabled"/>
<int value="-894214299" label="fill-on-account-select:enabled"/> <int value="-894214299" label="fill-on-account-select:enabled"/>
<int value="-894185031" label="HighDynamicRange:disabled"/> <int value="-894185031" label="HighDynamicRange:disabled"/>
<int value="-893673593" label="BentoOffline:disabled"/>
<int value="-892428689" label="ManualPasswordGenerationAndroid:enabled"/> <int value="-892428689" label="ManualPasswordGenerationAndroid:enabled"/>
<int value="-891856063" label="MidiManagerAndroid:enabled"/> <int value="-891856063" label="MidiManagerAndroid:enabled"/>
<int value="-889670978" label="AssistantRoutines:disabled"/> <int value="-889670978" label="AssistantRoutines:disabled"/>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment