Commit 00796e73 authored by Xianda Sun's avatar Xianda Sun Committed by Commit Bot

Do not record Event.AsyncTargeting.ResponseTime when verifying results

We now count async verifying time in Event.AsyncTargeting.ResponseTime
and this is not expected. This patch excludes verifying data from the
metric.

Bug: 900638
Change-Id: Ida75dc486746f033d6f2563846e37ebf6ee00ee9
Reviewed-on: https://chromium-review.googlesource.com/c/1310453Reviewed-by: default avatarRia Jiang <riajiang@chromium.org>
Reviewed-by: default avatarRobert Kroeger <rjkroege@chromium.org>
Commit-Queue: Xianda Sun <sunxd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604379}
parent 8b476905
...@@ -62,11 +62,15 @@ class TracingUmaTracker { ...@@ -62,11 +62,15 @@ class TracingUmaTracker {
~TracingUmaTracker() = default; ~TracingUmaTracker() = default;
TracingUmaTracker(TracingUmaTracker&& tracker) = default; TracingUmaTracker(TracingUmaTracker&& tracker) = default;
void StopAndRecord() {
Stop();
UmaHistogramTimes(metric_name_, base::TimeTicks::Now() - start_time_);
}
void Stop() { void Stop() {
TRACE_EVENT_ASYNC_END0( TRACE_EVENT_ASYNC_END0(
tracing_category_, metric_name_, tracing_category_, metric_name_,
TRACE_ID_WITH_SCOPE(metric_name_, TRACE_ID_LOCAL(id_))); TRACE_ID_WITH_SCOPE(metric_name_, TRACE_ID_LOCAL(id_)));
UmaHistogramTimes(metric_name_, base::TimeTicks::Now() - start_time_);
} }
private: private:
...@@ -342,7 +346,11 @@ void RenderWidgetTargeter::FoundFrameSinkId( ...@@ -342,7 +346,11 @@ void RenderWidgetTargeter::FoundFrameSinkId(
const viz::FrameSinkId& expected_frame_sink_id, const viz::FrameSinkId& expected_frame_sink_id,
const viz::FrameSinkId& frame_sink_id, const viz::FrameSinkId& frame_sink_id,
const gfx::PointF& transformed_location) { const gfx::PointF& transformed_location) {
tracker.Stop(); if (expected_frame_sink_id.is_valid()) {
tracker.Stop();
} else {
tracker.StopAndRecord();
}
uint32_t last_id = expected_frame_sink_id.is_valid() ? last_verify_request_id_ uint32_t last_id = expected_frame_sink_id.is_valid() ? last_verify_request_id_
: last_request_id_; : last_request_id_;
bool in_flight = expected_frame_sink_id.is_valid() ? verify_request_in_flight_ bool in_flight = expected_frame_sink_id.is_valid() ? verify_request_in_flight_
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment