Go back to unconditionally skipping fields in generated files.
bartekn@ has kindly identified r819402 as a source of performance regression in rewriter runtime - the numbers below represent the time (in minutes) of the 1st pass, 2nd pass and the total rewrite runtime: Before crrev.com/c/2488744: 89, 89, 196 After crrev.com/c/2488744: 167, 165, 349 To improve rewrite performance, this CL goes back to unconditionally skipping fields in generated files (i.e. partially reverts crrev.com/c/2488744). This is okay, because we have already gathered and stored the statistics about the skipped fields in generated files here: https://drive.google.com/file/d/1L27GU76qZZspq-AVLdIamsl61FKazPuf/view?usp=sharing Bug: 819402 Change-Id: Ie00b326c800ee68fabe64fd2ad12f18e69bc8f0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507233Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#822790}
Showing
Please register or sign in to comment